refactor: remove unused convertElkEdgesToEdges function #263
+11
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MH4GF
temporarily deployed
to
preview - erd-sample
GitHub Actions
Inactive
MH4GF
changed the title
MH4GF
requested review from
hoshinotsuyoshi,
FunamaYukina,
junkisai and
sasamuku
and removed request for
a team
|
@junkisai I would like you to review! |
junkisai
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the looks of it, the edges returned by elk.layout() do not change any particular information, so setEdges was removed.
The motivation is to reduce re-rendering as much as possible due to performance issues when it comes to large ER diagrams.
The only information that changed was the opacity, but in the case of edge, it seemed to have been displayed without changing even if
opacity: 0.